Fix toggling showLine option on scatter controller (#11334)

chartjs · Jun 8, 2023 · ec7be48 · ec7be48
1 parent 6348f9c
commit ec7be48
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 0 deletions.
diff --git a/src/controllers/controller.scatter.js b/src/controllers/controller.scatter.js
@@ -70,6 +70,10 @@ export default class ScatterController extends DatasetController {
 
     if (this.options.showLine) {
 
+      // https://github.com/chartjs/Chart.js/issues/11333
+      if (!this.datasetElementType) {
+        this.addElements();
+      }
       const {dataset: line, _dataset} = meta;
 
       // Update Line
@@ -84,6 +88,10 @@ export default class ScatterController extends DatasetController {
         animated: !animationsDisabled,
         options
       }, mode);
+    } else if (this.datasetElementType) {
+      // https://github.com/chartjs/Chart.js/issues/11333
+      delete meta.dataset;
+      this.datasetElementType = false;
     }
 
     // Update Points

diff --git a/test/fixtures/controller.scatter/showLine/changed.js b/test/fixtures/controller.scatter/showLine/changed.js
@@ -0,0 +1,34 @@
+module.exports = {
+  description: 'showLine option should draw a line if true',
+  config: {
+    type: 'scatter',
+    data: {
+      datasets: [{
+        data: [{x: 10, y: 15}, {x: 15, y: 10}],
+        pointRadius: 10,
+        backgroundColor: 'red',
+        label: 'dataset1'
+      }],
+    },
+    options: {
+      scales: {
+        x: {
+          display: false
+        },
+        y: {
+          display: false
+        }
+      }
+    }
+  },
+  options: {
+    canvas: {
+      width: 256,
+      height: 256
+    },
+    run(chart) {
+      chart.options.showLine = true;
+      chart.update();
+    }
+  }
+};
diff --git a/test/fixtures/controller.scatter/showLine/changed.png b/test/fixtures/controller.scatter/showLine/changed.png