Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flickering on mouseover in 2.0 #1381

Closed
bedenko opened this issue Aug 16, 2015 · 10 comments
Closed

flickering on mouseover in 2.0 #1381

bedenko opened this issue Aug 16, 2015 · 10 comments

Comments

@bedenko
Copy link

bedenko commented Aug 16, 2015

http://jsbin.com/quduji/edit?html,js,output

When doing .update(), data gets loaded, but sometimes not shown. On mouseover i get flickering, and eventually on mouseout data gets displayed.
This is not happening always, so please try toggling between Day/Week/Month until data does not get shown, and afterwards try the mouse-over.

Is this a bug or PEBCAK?

@tannerlinsley
Copy link
Contributor

This a bug. Not sure what's causing it. I think its because there are elements trying to animate from null to not null values. We'll look into this more.

@etimberg
Copy link
Member

I have a hunch that the issue is related to the way update works. I think the elements don't have a starting value when they are updated in.

@tannerlinsley
Copy link
Contributor

Yeup. That's it I think.

On Fri, Aug 28, 2015 at 4:29 PM Evert Timberg notifications@github.com
wrote:

I have a hunch that the issue is related to the way update works. I think
the elements don't have a starting value when they are updated in.


Reply to this email directly or view it on GitHub
#1381 (comment).

@etimberg etimberg added the v2.x label Aug 29, 2015
@etimberg
Copy link
Member

I think this line might be related, but it's only a hunch. It would trigger accidentally if the value is 0. https://github.com/nnnick/Chart.js/blob/v2.0-dev/src/core/core.element.js#L44

@etimberg
Copy link
Member

etimberg commented Sep 1, 2015

@bedenko I can't open your fiddle any more for some reason

@bedenko
Copy link
Author

bedenko commented Sep 1, 2015

Strange....

Well, i made a new copy:
https://jsbin.com/ganuri/edit

@etimberg
Copy link
Member

etimberg commented Sep 1, 2015

Thanks! I tested against a new build of Chart.js. A lot of the flicker was fixed and was related to #1384. For some reason the 2nd point still flickers when going from 'day' to 'week'. I'll try and get an answer there soon,

@bedenko
Copy link
Author

bedenko commented Sep 1, 2015

Excellent!

So you will push the commit to v2.0-dev, when you find that last problem?
Or does a "sneak preview" of this fix exist somewhere?

@etimberg
Copy link
Member

etimberg commented Sep 1, 2015

I will push the fix when I find it. I have an idea where it is, but I'm not 100% sure.

@etimberg
Copy link
Member

Fixed in #1653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants