Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison table seems to have invalid characters #3441

Closed
tiesont opened this issue Oct 7, 2016 · 7 comments
Closed

Comparison table seems to have invalid characters #3441

tiesont opened this issue Oct 7, 2016 · 7 comments

Comments

@tiesont
Copy link
Contributor

tiesont commented Oct 7, 2016

Viewing the Charting Library Comparison section (http://www.chartjs.org/docs/#notes-charting-library-comparison), I assume there should be something like a checkmark, but this is what I see:

notes-charting-library-comparison

Using Windows 10, I see the same thing in Firefox, Chrome, and Edge, so I don't think it's a browser issue.

@etimberg
Copy link
Member

etimberg commented Oct 7, 2016

Thanks for reporting this @tiesont

This is reproducing on my MBP in Chrome as well
@zachpanz88 thoughts?

@panzarino
Copy link
Contributor

panzarino commented Oct 8, 2016

The problem is that the site will only render ASCII and not utf-8 characters (I assume, it depends on how the script @nnnick uses to generate the site works). There should be check marks there as shown in the markdown file. The check mark will have to be replaced with something different, such as an "X" or "Yes".

@tiesont
Copy link
Contributor Author

tiesont commented Oct 8, 2016

Would probably be a simple matter of replacing the character with an entity:

✓
✓
✓
✓

are all options.

If the documentation site includes the charset meta element:

<meta charset="utf-8" />

the ticks render correctly, so perhaps that is a quicker fix.

@panzarino
Copy link
Contributor

panzarino commented Oct 8, 2016

That would probably work, I would like to verify with @nnnick before merging anything, but feel free to submit a PR with the fix.

@tiesont
Copy link
Contributor Author

tiesont commented Oct 8, 2016

@zachpanz88 Sorry, just edited my comment. I saved a local copy of the page and swapped out

<meta http-equiv="content-type" content="text/html; charset=windows-1252">

with

<meta charset="utf-8" />

and the Unicode characters show up, so I assume the meta tag is just wrong (I don't know what charset windows-1252 is - I assume ASCII or UTF-7).

@tiesont
Copy link
Contributor Author

tiesont commented Oct 8, 2016

Swapped the characters in #3444 - should be good-to-go?

@etimberg
Copy link
Member

Fixed in #3444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants