-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Retina scaling no longer working in 2.4.0 (master branch) #3575
Comments
Can you drop an example (HTML + JavaScript), here or in a jsFiddle? |
Any example should do the trick (such as using the Getting Started example in the documentation). I would put together a JSFiddle but I don't think I can have it use 2.4.0 since it isn't released yet. If this is possible, let me know and I certainly will! But here are a couple screenshots: Using 400x400 with responsive set to false: With responsive set to true: Both charts appear as 800x800 and are twice as big as they should be. |
Yep, the Getting Started example will work. |
You right, it's broken since this commit change. I just didn't think about that retina case when only the canvas width/height are set. The proper way to size a chart (IMO) is to set the canvas style only: |
However, do we agree that the |
Ah, setting the width/height in style does indeed solve the issue! Thanks. And yup, the |
@Driklyn can you please pull latest master and confirm that it's fixed? |
Yep, looks good now whether you're using Thanks for the quick fix! 👍 |
thanks @Driklyn for verifying this |
Testing out the latest using the master branch (since I needed a new feature) and now my charts are twice as big and blurry.
I believe it is related to this commit.
Expected Behavior
Using a width/height of 640x480, a canvas is created like so:
Current Behavior
With
responsive
set tofalse
, the canvas is created as:With
responsive
set totrue
, the canvas is created as:The text was updated successfully, but these errors were encountered: