Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix options update when changing to shared opts #10451

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Fix options update when changing to shared opts #10451

merged 1 commit into from
Jun 29, 2022

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Jun 28, 2022

Fix #10418

The options were not included in the update, because the new options were shared and the old ones were not.

@kurkle kurkle added this to the Version 3.8.1 milestone Jun 28, 2022
@kurkle kurkle merged commit 7a13906 into chartjs:master Jun 29, 2022
@kurkle kurkle deleted the scriptable-to-value branch June 29, 2022 13:44
@Zelilac Zelilac mentioned this pull request May 28, 2024
Open
@jennytoc jennytoc mentioned this pull request Jun 28, 2024
Open
@tobistudio tobistudio mentioned this pull request Jul 17, 2024
Closed
@Hailfire805 Hailfire805 mentioned this pull request Jul 23, 2024
Open
@tobistudio tobistudio mentioned this pull request Jul 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 3.8.1
Development

Successfully merging this pull request may close these issues.

myChart.options.elements.point.radius = 5; then chart.update()
2 participants
@kurkle @etimberg