Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint before build & test, remove lint from test #10462

Merged
merged 4 commits into from
Jul 7, 2022

Conversation

LeeLenaleee
Copy link
Collaborator

Remove the lint from test since its a duplicate step, also do it before building so it saves CI time

@LeeLenaleee
Copy link
Collaborator Author

Might be worth to see if the build step can store its build and reuse it in test so that also does not have to be executed twice.

etimberg
etimberg previously approved these changes Jul 1, 2022
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise looks good to me

package.json Outdated Show resolved Hide resolved
@etimberg etimberg merged commit 3fe5811 into chartjs:master Jul 7, 2022
@LeeLenaleee LeeLenaleee deleted the infra/split-test-lint branch July 7, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants