Use parser options in getPixelForValue for time scale #3131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 to merge |
| @@ -338,7 +338,7 @@ module.exports = function(Chart) { | |||
| var me = this; | |||
| if (!value || !value.isValid) { | |||
| // not already a moment object | |||
| value = moment(me.getRightValue(value)); | |||
| value = me.parseTime(me.getRightValue(value)); | |||
There was a problem hiding this comment.
...ya know, you could have just used this here... ;)
There was a problem hiding this comment.
this would work, but this cannot be minified. Since this would be used in a bunch of places, we do var me = this so that me can be minified in the function. In a single function this doesn't save much, but over the entire lib it saves a few kB.
There was a problem hiding this comment.
If I did my maths correctly, it currently saves 4KB (~3%) on the minified version.
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Use parser options in getPixelForValue for time scale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that data points can be correctly located even if the time scale uses a custom parser.