Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multiline labeling for tooltips in doughnut charts #3325

Merged
merged 2 commits into from
Sep 24, 2016

Conversation

etimberg
Copy link
Member

Change the default doughnut chart tooltip callback to better handle multiline labels. I put the value on the first line. I think this is fine since it matches how the color box is drawn in the label.

Fixes #3269

After Changes

doughnut multiline tooltip

@simonbrunel
Copy link
Member

Looks good. I think we could even get rid of defaultConfig.tests.js and move these tests next to the associated classes (e.g. bubble chart default config in controller.bubble.tests.js, etc.). If it make sense, we can do that later of course.

@etimberg
Copy link
Member Author

yeah, these are becoming much more chart specific so we can move them into the controller tests at some point

@simonbrunel simonbrunel merged commit d407da4 into master Sep 24, 2016
@simonbrunel simonbrunel deleted the fix/3269 branch September 24, 2016 20:31
@simonbrunel simonbrunel added this to the Version 2.4 milestone Sep 24, 2016
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Improve multiline labeling for tooltips in doughnut charts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants