Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added watchify dev dep #3414

Merged
merged 1 commit into from
Oct 4, 2016
Merged

Conversation

fewstera
Copy link
Contributor

@fewstera fewstera commented Oct 4, 2016

When trying to run gulp unittestWatch I got an error for a missing watchify dep. This PR fixes it 👍

@simonbrunel
Copy link
Member

That's weird, watchify should not be a dependency anymore and I can't find where it's used in the project. gulp unittestWatch works for me, even after a fresh clone and npm install. What npm version do you use?

@fewstera
Copy link
Contributor Author

fewstera commented Oct 4, 2016

➜ node -v
v4.5.0
➜ npm -v
3.10.6
➜ gulp -v
[13:29:30] CLI version 3.9.0
[13:29:30] Local version 3.9.1

@fewstera
Copy link
Contributor Author

fewstera commented Oct 4, 2016

From the npm blog:

We will also be changing the behavior of peerDependencies in npm@3. We won’t be automatically downloading the peer dependency anymore. Instead, we’ll warn you if the peer dependency isn’t already installed. This requires you to resolve peerDependency conflicts yourself, manually, but in the long run this should make it less likely that you’ll end up in a tricky spot with your packages’ dependencies.

On a fresh install I'm getting:
karma-browserify@5.1.0 requires a peer of watchify@>=3 <4 but none was installed.

So I'm guessing this is where the issue comes from.

https://github.com/nikku/karma-browserify/blob/master/package.json#L60

@simonbrunel
Copy link
Member

Nice catch, I'm on npm 2.15.5, that's why it works for me. Can you please amend your commit message to add a more meaningful description, like that we will not delete it again next time the project dependencies are cleaned up :)

@fewstera
Copy link
Contributor Author

fewstera commented Oct 4, 2016

@simonbrunel better commit message added. 👍

Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge

@etimberg etimberg merged commit 99b8d67 into chartjs:master Oct 4, 2016
@simonbrunel simonbrunel modified the milestone: Version 2.4 Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants