New fill modes for lines #3460
Merged
New fill modes for lines #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good but just thinking: do we really need a new option?
|
|
I can condense down to a single option |
|
@simonbrunel updated to use a single option |
simonbrunel
approved these changes
Oct 14, 2016
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
New fill modes for lines allowing the user to customize where the fill goes to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to customize how the line fills.
A new
fillModeproperty configures this. It defaults to'zero'which matches the current behaviour. It can also be set to'top'or'bottom'.Top Mode
Bottom Mode
Fixes #3176