Added Patch to update tooltip only when active element has changed #3856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
reviewed
Feb 1, 2017
There was a problem hiding this comment.
Other than my 2 very minor comments, I think this is good to go.
Good job @Jareechang
src/core/core.tooltip.js
Outdated
| @@ -782,6 +782,11 @@ module.exports = function(Chart) { | |||
|
|
|||
| // Remember Last Actives | |||
| changed = !helpers.arrayEquals(me._active, me._lastActive); | |||
|
|
|||
| if (!changed) { | |||
There was a problem hiding this comment.
Could you add a comment here explaining why this exists? It might be a good idea to include a link to the relevant github issue as well
There was a problem hiding this comment.
ah good idea, that i'll add that in.
test/core.tooltip.tests.js
Outdated
| @@ -674,4 +674,65 @@ describe('Core.Tooltip', function() { | |||
| expect(tooltip._view.dataPoints[0].x).toBeCloseToPixel(point._model.x); | |||
| expect(tooltip._view.dataPoints[0].y).toBeCloseToPixel(point._model.y); | |||
| }); | |||
|
|
|||
| it('Should not update if active element has not changed', function() { | |||
| var chartInstance = window.acquireChart({ | |||
There was a problem hiding this comment.
[minor] We are trying to standardize on chart rather than chartInstance.
There was a problem hiding this comment.
sure! quick fix, no problem.
Jareechang
force-pushed
the
issue/#3746
branch
from
89db799
to
863afc5
Compare
(chartjs#3746) skip handleEvent (and update) if the element has not change changed chartInstance to chart in test added comment for code preventing tooltip update if there is not changes
simonbrunel
approved these changes
Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title states, added patch for Issue #3746 with test cases. Please review when you have a chance! @etimberg or @simonbrunel.