Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero line dash options #4019

Merged
merged 1 commit into from
Mar 21, 2017
Merged

Zero line dash options #4019

merged 1 commit into from
Mar 21, 2017

Conversation

lndobryden
Copy link
Contributor

  • Add border dash options for zero line

  • Update Readme with zero line border dash config options

@lndobryden
Copy link
Contributor Author

lndobryden commented Mar 14, 2017

This change set exposes a couple more styling options and should help address this issue:
#3821

I'm working on putting a plnkr together to showcase the issue and how this change set fixes it.

@etimberg
Copy link
Member

Looks good code wise to me. Would love to see a fiddle of it in action

@simonbrunel
Copy link
Member

@lndobryden can you push/force push to your branch to trigger a new Travis build please?

@lndobryden
Copy link
Contributor Author

Hi,
Here's a quick plunker.
https://plnkr.co/edit/T2rIKlwlD9MkbGcktsYG
I commented out the relevant new options. Let me know how it looks!

@etimberg
Copy link
Member

@lndobryden looks good 👍

@lndobryden
Copy link
Contributor Author

👍 Great!

@etimberg etimberg added this to the Version 2.6 milestone Mar 15, 2017
@etimberg
Copy link
Member

@lndobryden we merged a PR that changes the docs over to use GitBook. Is it possible to rebase this against master so that we can merge it?

* Add of zero line border dash options

* Update Readme with zero line border dash config options
@lndobryden
Copy link
Contributor Author

Hi @etimberg,
I think that should do it. Do you think this can get merged soon?

  • Lee

@etimberg
Copy link
Member

Thanks @lndobryden I will merge this now

@etimberg etimberg merged commit 20a8328 into chartjs:master Mar 21, 2017
roicos pushed a commit to roicos/Chart.js that referenced this pull request Aug 21, 2017
* Add of zero line border dash options
* Update Readme with zero line border dash config options
@shokry-suleiman
Copy link

shokry-suleiman commented Sep 7, 2020

                          yAxes: [ {
                            
                                gridLines: {
                                   
                                    zeroLineBorderDash:[2,2]
                                    

                                },                  
                            }],
                            xAxes: [{
                                
                                gridLines: {
                                 
                                    zeroLineColor: '#e7e8ee',
                                    zeroLineBorderDash:[5,3]

                                },
                            }],

exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
* Add of zero line border dash options
* Update Readme with zero line border dash config options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants