Coloring an axis line separately from gridLines #4058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AxisLine color can be set with axisColor option inside gridLines option Add default setting
* Update core.helpers.tests.js * Update scale.category.tests.js * Update scale.linear.tests.js * Update scale.logarithmic.tests.js * Update scale.radialLinear.tests.js * Update scale.time.tests.js
simonbrunel
reviewed
Mar 22, 2017
src/core/core.scale.js
Outdated
| @@ -730,7 +731,7 @@ module.exports = function(Chart) { | |||
| if (gridLines.drawBorder) { | |||
| // Draw the line at the edge of the axis | |||
| context.lineWidth = helpers.getValueAtIndexOrDefault(gridLines.lineWidth, 0); | |||
| context.strokeStyle = helpers.getValueAtIndexOrDefault(gridLines.color, 0); | |||
| context.strokeStyle = helpers.getValueAtIndexOrDefault(gridLines.axisColor, 0); | |||
There was a problem hiding this comment.
I'm wondering what's the difference between zeroLineColor and axisColor?
There was a problem hiding this comment.
zeroLineColor affects only the line at 0, which could be in the middle of the graph(e.g. min: -20, max: 20) or not displayed at all(e.g. min: 50, max: 100).
axisColor is always the border line near ticks
also zeroLineColor affects the other axis(see pic)
There was a problem hiding this comment.
Understood :) @etimberg what do you think about the option name axisColor?
simonbrunel
approved these changes
Mar 23, 2017
etimberg
reviewed
Mar 25, 2017
etimberg
approved these changes
Mar 27, 2017
This was referenced Mar 31, 2017
|
Solved and extended by #4117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the axisColor option and its functionality to GridLines options, mentioned in issue #4041
Also updated the axes documentation.