Fix wild special zero grid line when undefined #4700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the special drawing for an undefined zero grid line since it causes issue when the first tick is not anymore aligned on the scale extremity. Only linear based scales now display a special grid line for the origin. Hide scales in the filler plugin unit test fixtures to avoid future failures due to changes unrelated to the tested features.
etimberg
approved these changes
Aug 25, 2017
yofreke
pushed a commit
to yofreke/Chart.js
that referenced
this pull request
Dec 30, 2017
Remove the special drawing for an undefined zero grid line since it causes issue when the first tick is not aligned on the scale extremity (ie only linear scales now display a special grid line for the origin). Hide scales in the filler plugin unit test fixtures to avoid future failures due to changes unrelated to the tested features.
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Remove the special drawing for an undefined zero grid line since it causes issue when the first tick is not aligned on the scale extremity (ie only linear scales now display a special grid line for the origin). Hide scales in the filler plugin unit test fixtures to avoid future failures due to changes unrelated to the tested features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the special drawing for an
undefinedzero grid line since it causes issue when the first tick is not aligned on the scale extremity (only linear based scales now display a special grid line for the origin).Also hide scales in the filler plugin unit test fixtures to avoid future failures due to changes unrelated to the tested features. This should help implementing #4117 without worrying about the filler unit tests.
CC @Zamaroth @andig