Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding hooks "beforeTooltipDraw" and "afterTooltipDraw" to plugins #4793

Merged
merged 9 commits into from Oct 14, 2017
Merged

Adding hooks "beforeTooltipDraw" and "afterTooltipDraw" to plugins #4793

merged 9 commits into from Oct 14, 2017

Commits on Sep 25, 2017

  1. Adding hook "beforeTooltips" to call plugins.notify immediately befor… 

    …e drawing tooltips.
    jfarkas committed Sep 25, 2017
    Configuration menu
    Copy the full SHA
    8343e6a View commit details
    Browse the repository at this point in the history

  2. fixing tabs/spaces issues

    jfarkas committed Sep 25, 2017
    Configuration menu
    Copy the full SHA
    eaa1967 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2017

  1. Changing "beforeTooltips" to "beforeTooltipDraw" per @simonbrunel: "t… 

    …o be more explicit and thus durable (e.g. if we decide to add beforeTooltipUpdate or whatever related to the tooltip)? Also, since there is only one managed tooltip, not sure it should be plural."
    @JewelsJLF
    JewelsJLF committed Oct 1, 2017
    Configuration menu
    Copy the full SHA
    af9c0ad View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/chartjs/Chart.js into bef… 

    …oreTooltips
    @JewelsJLF
    JewelsJLF committed Oct 1, 2017
    Configuration menu
    Copy the full SHA
    60e9f5d View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2017

  1. Making hook consistent with *DatasetDraw by adding function "drawTool… 

    …tip" that handles the plugin notifications (beforeTooltipDraw and afterTooltipDraw) and tooltip drawing.
    @JewelsJLF
    JewelsJLF committed Oct 14, 2017
    Configuration menu
    Copy the full SHA
    82d981e View commit details
    Browse the repository at this point in the history

  2. Fixing spaces/tabs issue.

    @JewelsJLF
    JewelsJLF committed Oct 14, 2017
    Configuration menu
    Copy the full SHA
    3455ccf View commit details
    Browse the repository at this point in the history

  3. changing drawTooltip to _drawTooltip

    @JewelsJLF
    JewelsJLF committed Oct 14, 2017
    Configuration menu
    Copy the full SHA
    c2d99ab View commit details
    Browse the repository at this point in the history

  4. moving options after arg.easingValue

    @JewelsJLF
    JewelsJLF committed Oct 14, 2017
    Configuration menu
    Copy the full SHA
    221f484 View commit details
    Browse the repository at this point in the history

  5. updating unit tests

    @JewelsJLF
    JewelsJLF committed Oct 14, 2017
    Configuration menu
    Copy the full SHA
    adbe040 View commit details
    Browse the repository at this point in the history