Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced pipe by 'or' so md won't columnify it #4832

Closed
wants to merge 1 commit into from
Closed

replaced pipe by 'or' so md won't columnify it #4832

wants to merge 1 commit into from

Conversation

einfallstoll
Copy link
Contributor

No description provided.

@benmccann
Copy link
Contributor

Thanks for the PR!
We had some discussion about this on #4822. It seems the consensus was to try to standardize on /

@einfallstoll
Copy link
Contributor Author

Ok, but a few rows below the table uses "or". Therefore it would be consistent with the other documentation

Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@einfallstoll thanks for the PR and you right, we should also get rid of the or separator. If you agree, can you please update your PR and make separator consistent through all the docs (i.e. use / instead of | and or), but also replace what have been done in #4827?

@benmccann
Copy link
Contributor

This has been fixed in master

@benmccann benmccann closed this Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants