Float-bar support. The logic is to use array values [bottomY, topY] i… #5262
Commits on Feb 11, 2018
-
Float-bar support. The logic is to use array values [bottomY, topY] i…
…nstead of regular vals. SO if you use regular numbers char will be not floated and bottomY will be 0 by default. If you use array for value current update allowing to track this and use bottomY value from array instead of 0.)
-
-
-
-
-
-
Commits on Feb 12, 2018
Commits on Feb 14, 2018
Commits on Feb 22, 2018
-
-
CHanges as requested simonbrunel
A few early feedback: instead of duplicating the logic to pick the "right" value in each scale, it may be better to move it directly in getRightValue()? Though, that would need some investigation to be sure it doesn't break anything. I would not introduce the new borderSkipped: 'none' value, but instead support borderSkipped: false|null. I would not call it lowY or highY but low/hight or min/max
Commits on Feb 23, 2018
Commits on Feb 24, 2018
Commits on May 7, 2018
Commits on May 8, 2018
-
-
element code formatting change
corners from 5 to 4 if borderskipped is null, cycle from < to <=
Commits on May 15, 2018
-
1. new method in core.scales to handle arrays (float-bars), getRightV…
…alueLowHigh() - it returns lowY, highY and actual Y value; Method is called from original getRightValue when incoming data is actuall array. 2. Label updates, so now it returns data in format join(' ; ') values (lowY and high Y). Labels are generated from proper scale code for float-bars 3. Proper scale build. Now for negative or positive values scale are getting correct value from a pait of Y values (lowY and highY) link for testing - http://pravopys.net/chartjs/samples/charts/bar/stacked-vertical-simon.html
Commits on May 16, 2018
Commits on May 18, 2018
Commits on May 21, 2018
-
parseValue is in scale.js, returns data as object with min, max and val. This functions is used in controller.bar.js to calculate start point and gap for floating-bar. Also this functiotn is used in scale.linearjs and scale.logarithmic.js to calculate scale min and max values and label texts.
-
-
Commits on May 22, 2018
Commits on May 23, 2018
Commits on May 24, 2018
Commits on May 29, 2018
Commits on Jun 4, 2018
Commits on Jun 5, 2018
Commits on Jun 8, 2018
Commits on Jun 11, 2018
Commits on Jun 18, 2018
Commits on Jun 19, 2018
Commits on Jun 20, 2018
Commits on Jun 27, 2018
Commits on Jan 17, 2019
Commits on Jan 18, 2019
Commits on Feb 5, 2019
Commits on Feb 8, 2019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.