Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle '\n' as newline in tooltips #5521

Merged
merged 2 commits into from
Jun 5, 2018
Merged

Handle '\n' as newline in tooltips #5521

merged 2 commits into from
Jun 5, 2018

Conversation

CWSites
Copy link
Contributor

@CWSites CWSites commented May 25, 2018

Proposed fix for #4087 based on #4590 using latest code. If there is anything else I can do to help please let me know.

Fixes #4087

@@ -457,6 +471,13 @@ function getBackgroundPoint(vm, size, alignment, chart) {
};
}

/**
* @Helper to build before and after body lines
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @ here seems unusual to me

@CWSites
Copy link
Contributor Author

CWSites commented May 30, 2018

Hey @benmccann I made your requested changes, any update on getting this fix merged in?

@benmccann
Copy link
Contributor

@CWSites thanks! I don't have merge access, so you'll need @etimberg or @simonbrunel to merge it. Usually they merge it after both of them have signed off on it. I see @simonbrunel has already approved, so you'll probably just need @etimberg to review now

@CWSites
Copy link
Contributor Author

CWSites commented May 30, 2018

Awesome thank you!

@CWSites
Copy link
Contributor Author

CWSites commented Jun 5, 2018

bump @etimberg, would really like to get this fix merged in.

@simonbrunel simonbrunel added this to the Version 2.8 milestone Jun 5, 2018
@simonbrunel simonbrunel changed the title Bugfix/4087 Handle '\n' as newline in tooltips Jun 5, 2018
@simonbrunel simonbrunel merged commit 8198d76 into chartjs:master Jun 5, 2018
@simonbrunel
Copy link
Member

@CWSites thanks.

@etimberg I merged it since you already approved #4590 and nothing really changed.

@CWSites
Copy link
Contributor Author

CWSites commented Jun 5, 2018

Thanks @simonbrunel, how will I know what version this is included in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Newline in tooltips gets converted to a space
3 participants