Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check pixel values within the logarithmic scale unit test using the pixel proximity matcher #5833

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

jtagscherer
Copy link
Contributor

Previously, unit tests for the logarithmic scale within scale.logarithmic.tests.js used the precise toBe matcher to compare pixel values instead of the more appropriate toBeCloseToPixel matcher. This lead to failed test cases due to floating point inaccuracies and is inconsistent when compared to scale.linear.tests.js.

This PR resolves this issue by replacing matchers for explicit pixel comparisons.

Fixes #5829.

@simonbrunel simonbrunel added this to the Version 2.8 milestone Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test for logarithmic scale fails in Firefox
3 participants