Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reverse support to time scale #5927

Merged
merged 5 commits into from
Dec 20, 2018
Merged

Add reverse support to time scale #5927

merged 5 commits into from
Dec 20, 2018

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Dec 19, 2018

Simpler approach for reversing time scale.
What I don't know is why those labels rotate, that needs to be investigated still.

Tests adopted from PR: #5731

3279
(tick rotation fixed in fiddle)

2.7.3: https://jsfiddle.net/rr3ftzge/40/
PR: https://jsfiddle.net/9cr418ty/1/
Updated PR: https://jsfiddle.net/9cr418ty/2/

Closes #5731
Fixes #3279

etimberg
etimberg previously approved these changes Dec 19, 2018
benmccann
benmccann previously approved these changes Dec 20, 2018
actually reverse the ticks, to be combatible with other implementations
revert change to core.scale.js (not needed anymore)
@kurkle kurkle dismissed stale reviews from benmccann and etimberg via ef52acb December 20, 2018 09:24
@kurkle
Copy link
Member Author

kurkle commented Dec 20, 2018

Changed start to end as @simonbrunel suggested and noticed and fixed a issue.

5927

@simonbrunel
Copy link
Member

Does it work correctly with other bound and distribution option values?

@kurkle
Copy link
Member Author

kurkle commented Dec 20, 2018

Does it work correctly with other bound and distribution option values?

It does:
https://codepen.io/kurkle/full/gZgGWr

Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kurkle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need ability to reverse time scale
4 participants