Rebased master #6055
Closed
Rebased master #6055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of regular vals. SO if you use regular numbers char will be not floated and bottomY will be 0 by default. If you use array for value current update allowing to track this and use bottomY value from array instead of 0.)
A few early feedback: instead of duplicating the logic to pick the "right" value in each scale, it may be better to move it directly in getRightValue()? Though, that would need some investigation to be sure it doesn't break anything. I would not introduce the new borderSkipped: 'none' value, but instead support borderSkipped: false|null. I would not call it lowY or highY but low/hight or min/max
corners from 5 to 4 if borderskipped is null, cycle from < to <=
optimized code for bar.js and rectangle js as per Simon Brunel request
…alueLowHigh() - it returns lowY, highY and actual Y value; Method is called from original getRightValue when incoming data is actuall array.
2. Label updates, so now it returns data in format join(' ; ') values (lowY and high Y). Labels are generated from proper scale code for float-bars
3. Proper scale build. Now for negative or positive values scale are getting correct value from a pait of Y values (lowY and highY)
link for testing - http://pravopys.net/chartjs/samples/charts/bar/stacked-vertical-simon.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.