Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dataset metadata when axisID changes #6321

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Conversation

nagix
Copy link
Contributor

@nagix nagix commented Jun 6, 2019

When the dataset option xAxisID or yAxisID is changed and update() is called, it doesn't make any changes. This PR fixes it by modifying linkScales so that metadata is updated if dataset.xAxisID or dataset.yAxisID exists.

Master: https://jsfiddle.net/nagix/mwL6obck/
Screen Shot 2019-06-07 at 12 20 34 AM

This PR: https://jsfiddle.net/nagix/u7wta3ed/
Screen Shot 2019-06-07 at 12 21 02 AM

Fixes #6320

@benmccann benmccann changed the title Update dataset metadata when scaleID changes Update dataset metadata when axisID changes Jun 7, 2019
@benmccann
Copy link
Contributor

@nagix I updated the title and description from "scale" to "axis" to match the option name. Feel free to change back and let me know if I made a mistake

@nagix
Copy link
Contributor Author

nagix commented Jun 7, 2019

Thanks @benmccann, it looks good and correct🙂

@nagix nagix added the type: bug label Jun 7, 2019
@nagix nagix added this to the Version 2.9 milestone Jun 14, 2019
@nagix nagix merged commit 9eecdf4 into chartjs:master Jun 14, 2019
@nagix nagix deleted the issue-6321 branch June 15, 2019 09:48
charlesmass pushed a commit to charlesmass/Chart.js that referenced this pull request Jun 17, 2019
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset is displayed on other scale than configured via axisID
4 participants