Store parsed data more similarly to provided data #6814
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #6768 merged and
parsing: false
, the uPlot benchmark is still spending about 10% of its time in_parse
. This PR brings it down to a trivial amount.I think what is happening in
master
is that by adding a new_parsed
attribute to the element that the element can sometimes no longer fit in the memory allocated to it and so new memory must be allocated with the old being garbage collected. By just using thedata
directly we see a very big speedup