Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastline controller #6822

Closed
wants to merge 1 commit into from
Closed

fastline controller #6822

wants to merge 1 commit into from

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Dec 9, 2019

This is an idea I wanted to run past you guys.

It's a far faster controller for drawing a line graph because it doesn't create any elements.

I made it a separate controller for experimenting, but I wonder if it should be combined with the main one. Also, it doesn't use the new fastpath code, so could probably be made faster still.

Features it disables:

  • animation
  • bezier and stepped lines and spanGaps: false
  • drawing points (could be added back, but I didn't plan on it)
  • tooltips (I'd like to add this back)

@kurkle
Copy link
Member

kurkle commented Dec 11, 2019

How great performance improvement are we talking about?
I think this would be better off implemented externally. @etimberg what do you think?

@etimberg
Copy link
Member

Could we keep this external until it's got enough features/performance to warrant moving to the core? I don't want to increase our bundle size too much

@benmccann
Copy link
Contributor Author

It's about twice as fast. As we optimize the scale and other parts more then this will provide a larger improvement on a percentage basis.

I sent #6829 to allow implementing this externally

@benmccann
Copy link
Contributor Author

I'll close this for now and consider whether to implement it externally or try to move forward in some other way with it

@benmccann benmccann closed this Dec 14, 2019
@benmccann benmccann mentioned this pull request Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants