Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the DateAdapter to ES6 #7032

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Convert the DateAdapter to ES6 #7032

merged 1 commit into from
Jan 31, 2020

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Jan 30, 2020 •
edited

Extracted from #7030. Converts DateAdapter to an ES6 class, allows the DateAdapter to be used in TypeScript projects, and fixes a number of JSDoc errors.

kurkle
kurkle approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@etimberg etimberg added this to the Version 3.0 milestone Jan 31, 2020
@etimberg etimberg merged commit dac52d1 into chartjs:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: chore
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benmccann @etimberg @kurkle