[v3-beta][types] fix a wrong Option infer

[xr0master]

The issue is that "infer O" takes type from the Dataset type instead of Options.

export type ConfigurationOptions<O> = O extends IChartConfiguration<unknown, unknown, unknown, infer O> ? O : never;

It should be:

export type ConfigurationOptions<O> = O extends IChartConfiguration<unknown, unknown, unknown, unknown, infer O> ? O : never;

However we cannot set the unknown type for the dataset because unknown cannot be IChartDataset. Then I thought, why do we need to use an unknown type for no-need types? We can use the type definition everywhere and only return the type we need. Let me know what do you think about it.

[xr0master]

Rebased. I'll explain a little later why there is a bug.

[xr0master]

When we want to overwrite options of chartjs, we can see this issue: Property 'data' is missing

However, we don't have any "data" in the options. After checking the source, we can see that in the ConfigurationOptions "infer O" points on the dataset type, we can also see this in the type:

So it is.

[etimberg]

I think I follow what this is doing. @sgratzl thoughts as well?

[kurkle]

Only possible issue that comes to mind, is mixed charts:

const chart = new Chart(ctx, {
	type: 'bar',
	data: {
		datasets: [
			{data: [1, 2, 3]},
			{type: 'line', data: [3, 2, 1]}
		]
	}
});

Not quite sure if it is a problem, but I hope @xr0master can spot the issue if it exists :)

[sgratzl]

looks good to me

[xr0master]

@kurkle in very short, the issue is about the wrong position.
the IChartConfiguration type has 5 "arguments" and 5th is Options, however infer O points on 4th "argument". So, I moved the infer O to the 5th position. That's all this fix does.

[xr0master]

Only possible issue that comes to mind, is mixed charts:

I just now realized what the issue is in this example.
If I understand correctly, the purpose of these I*ControllerConfiguration types were to solve this problem. However, they are not used...

[xr0master]

So, if we want to strict types, we can do it like this:

const barChart = new Chart<number, string, IBarControllerConfiguration>(node, {
  type: 'bar',
  data: {
    datasets: [{
      type: 'bar',
      data: [],
    }]
  },
  options,
  plugins,
});

BTW dataset do not have type property, TS fails.

@emmcbd FYI

[kurkle]

I think this one does not really have anything to do with the mixed chart issue, so that can be solved separately.

[xr0master]

Yes, of course, I just noticed. To be honest, I'm not sure if there is an issue at all with mixed charts.