Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/type dateadapter override #8377

Merged
merged 4 commits into from
Feb 6, 2021
Merged

Fix/type dateadapter override #8377

merged 4 commits into from
Feb 6, 2021

Commits on Feb 4, 2021

  1. Not totally sure this is right , but since in core.adapters.js overri… 

    …de is part of the dateadapter it seems logical it should be there. Should also fix #8369
    @LeeLenaleee
    LeeLenaleee committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    390fc41 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. implemented feedback

    @LeeLenaleee
    LeeLenaleee committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    affb4e3 View commit details
    Browse the repository at this point in the history

  2. Declare the dataAdapter since it will be available at runtime if some… 

    …one overrides it
    @LeeLenaleee
    LeeLenaleee committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    998ad29 View commit details
    Browse the repository at this point in the history

  3. remove declaration. if this is giving problems in the future it might… 

    … need te be added again
    @LeeLenaleee
    LeeLenaleee committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    804b39e View commit details
    Browse the repository at this point in the history