-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doughnut/Pie chart border radius #8682
Conversation
I marked this as a draft for now so that we don't merge it until after v3.0.0 ships. It is ready for review |
Size Change: +1.51 kB (+1%) Total Size: 234 kB
|
Based on the size increase, I'll need to go through and really try and squeeze it down. Now that tests are in, it should be easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a test with really small radius, like 4 would be good to have too.
Now at Size Change: +1.66 kB (+1%) Total Size: 235 kB
|
Compressed size actually grew 🤔 |
Getting rid of the repeating strings hurt gzip. If we compromised on the API and used the same border radius as others, then I could reduce a lot by getting rid of the second option parsing implementation. |
b654b42
to
42fda97
Compare
Size Change: +1.5 kB (+1%) Total Size: 234 kB
|
|
d33c23d
to
0dc562f
Compare
Enables setting the
borderRadius
of arc elements (pie/doughnut charts). This can either be set as a single value, or an object specifying the radius for each corner. For the object, the keys areouterStart
,outerEnd
,innerStart
, andinnerEnd
since I thought thattopLeft
,topRight
,bottomLeft
, andbottomRight
would get confusing.Resolves #3644
Resolves #5503
Resolves #6653