Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legend: adjust lifecycle and event handling #8753

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Legend: adjust lifecycle and event handling #8753

merged 1 commit into from
Mar 30, 2021

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Mar 30, 2021

Fix #8750

https://codepen.io/kurkle/pen/PoWbqdx

  • itemHitBoxes are fully calcualated on update
  • match hoverItem by datasetIndex/index

@kurkle
Copy link
Member Author

kurkle commented Mar 30, 2021

Filename Size Change
dist/chart.esm.js 67.5 kB +274 B (0%)
dist/chart.js 85.5 kB +278 B (0%)
dist/chart.min.js 61 kB +219 B (0%)

@etimberg etimberg added this to the Version 3.0 milestone Mar 30, 2021
@etimberg etimberg merged commit 88c585b into chartjs:master Mar 30, 2021
@kurkle kurkle deleted the legend-fixes branch March 30, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Legend onClick not working on mobile with custom onHover
2 participants
@kurkle @etimberg