Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vuepress samples #8756

Merged
merged 61 commits into from
Apr 2, 2021
Merged

Vuepress samples #8756

merged 61 commits into from
Apr 2, 2021

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented Mar 30, 2021

Start moving samples to Vuepress

Sample To-Do List

@etimberg
Copy link
Member Author

etimberg commented Apr 1, 2021

@LeeLenaleee I added a to-do list here to track what's done/WIP. I was thinking about taking the scale options samples next

@LeeLenaleee
Copy link
Collaborator

Other charts is WIP

@LeeLenaleee
Copy link
Collaborator

Resolves #8672

Will need to delete the old samples folder and deploy of that folder before this gets merged

@etimberg
Copy link
Member Author

etimberg commented Apr 2, 2021

Yup, we'll need to remove the old samples for the master and next versions. I was thinking the order would be:

  1. Merge this PR
  2. Confirm new samples are visible (should be at https://chartjs.org/docs/master/samples)
  3. Remove old samples (and associated build steps)

Once v3 releases here, we'll need to update the main website landing page to point to the new samples https://github.com/chartjs/chartjs.github.io/blob/master/index.html#L45

We also likely want to change https://github.com/chartjs/chartjs.github.io/blob/master/samples/index.html to redirect to the new samples spot which will be /docs/latest/samples

@etimberg etimberg marked this pull request as ready for review April 2, 2021 12:00
@etimberg etimberg merged commit 66ee0fe into chartjs:master Apr 2, 2021
@etimberg etimberg deleted the vuepress-samples branch April 2, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants