Fix: Arc getCenterPoint when full circle #9152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
approved these changes
May 24, 2021
simonbrunel
reviewed
May 24, 2021
There was a problem hiding this comment.
A bit late since it's already merged but I don't think this fix is enough: the datalabels plugin don't use this method but startAngle and endAngle. I didn't investigate this issue but I feel that endAngle is % 360 somewhere for some internal calculations while it should not be modified on the instance.
|
Thanks @simonbrunel, I agree its not enough when those properties are used. So the fix is a bit more complex. |
|
All the Not sure the draw methods should change the element state. |
|
Agreed, it should use something internal when it needs to split the drawing in passes. And it really does not need many passes in this case. |
kurkle
added a commit
to kurkle/Chart.js
that referenced
this pull request
May 25, 2021
etimberg
pushed a commit
that referenced
this pull request
May 25, 2021
* Stop mutating arc state while drawing * No need for default values * Nits * Remove #9152 * Use correct endAngle for clipping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #9151