New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lower z index of scale border so it draws behind the chart elements again #9412
Closed
LeeLenaleee
wants to merge
12
commits into
chartjs:master
from
LeeLenaleee:fix/axis-line-behind-bubble
Closed
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
560d59d
lower z index of scale border so it draws behind the chart elements a…
LeeLenaleee 750c38b
lower default tick and grid z indez to -1 instead because color descr…
LeeLenaleee df49447
Limit Math.asin inputs to the range [-1, 1] (#9410)
etimberg 7105d90
revert label z-index back to original, use valueordefault for grid z …
LeeLenaleee fb45d8a
Update a failing fixture (#9414)
kurkle 11045a7
Fix center axis title positions (#9413)
etimberg 9473351
lower z index of scale border so it draws behind the chart elements a…
LeeLenaleee ad47217
lower default tick and grid z indez to -1 instead because color descr…
LeeLenaleee a9b7575
revert label z-index back to original, use valueordefault for grid z …
LeeLenaleee 5252ab9
add test js file
LeeLenaleee b262c2b
increase color and with of border so test will pick difference up
LeeLenaleee 330b51b
Merge branch 'fix/axis-line-behind-bubble' of https://github.com/LeeL…
LeeLenaleee File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use valueOrDefault, because you can't define z as
0
now. Does the tick z need to be changed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test wont fail if it isnt changed, but I thought since they where at the same z-index it would be logic to keep them at the same z-index