New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(workflow): add cache to workflows using actions/setup-node #9757
Conversation
With cache, the |
@etimberg what do you think of this? It did not look like it speeds anything up, but that is only bases on one run. Additional changes: |
Here you can find some official performance numbers from Checking your package.json you are using around ~50 For doing the comparison exercise I selected the following
And I'm taking the numbers from
Apparently there is no improvement for Windows (but no lost time) and a noticeable improvement for Ubuntu (for the 2 executions of CI I chose). @kurkle what are the timings you are checking and comparing where there is this |
Fixing this |
I'm ok with trying this out to see if it improves things. Agree that the |
I compared the runs on this pr, first run had no cache available and I triggered a 2nd run to see if the cache from previous run helps. These: I considered the |
Description
Add
cache
to workflows usingactions/setup-node
Context
setup-node
GitHub Action just released a new option to add cache to steps using it.You can find the details here: https://github.blog/changelog/2021-07-02-github-actions-setup-node-now-supports-dependency-caching/
🤖 This PR has been generated automatically by this octoherd script, feel free to run it in your GitHub user/org repositories! 💪🏾