Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.2.2 #24

Merged
merged 6 commits into from
Aug 17, 2020
Merged

Release 0.2.2 #24

merged 6 commits into from
Aug 17, 2020

Conversation

benmccann
Copy link
Collaborator

No description provided.

@etimberg etimberg merged commit f998af5 into release Aug 17, 2020
@Ben3eeE
Copy link

Ben3eeE commented Aug 18, 2020

It seems like 0.2.2 was not tagged and released after this was merged. Is that because the build is failing?

@benmccann
Copy link
Collaborator Author

Where do you see that the build is failing? The tests seem to pass locally for me although there are linting issues, which maybe would stop a release, so I sent a fix for that: #25

@Ben3eeE
Copy link

Ben3eeE commented Aug 18, 2020

I was looking in at the badge in the readme file to see that the build failed. Yeah, it seems to only be linting issues. It seems that PRs don't run on travis so this was not noticed before merging to release?

I am trying this out with chartjs 3.0.0-alpha2 with tree-shaking and ran into the issues that was fixed by PR #20. Linking this library locally from master fixed this issue but then I run into another issue:

This method is not implemented: either no adapter can be found or an incomplete integration was provided.

Importing like this:

import { Chart, LineController, Line, Point, LinearScale, TimeScale, Title } from 'chart.js';
import 'chartjs-adapter-luxon';

Chart.register(LineController, Line, Point, LinearScale, TimeScale, Title);

It seems like the adapter is not registered correctly. Not sure if I am importing it incorrectly. And I can't find any documentation on how to use this library with tree-shaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants