Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

startOf function is accepting number as weekday from 0(Sun) to 6(Sat) #18

Merged
merged 4 commits into from
Sep 7, 2020
Merged

startOf function is accepting number as weekday from 0(Sun) to 6(Sat) #18

merged 4 commits into from
Sep 7, 2020

Conversation

stockiNail
Copy link
Contributor

Fixes #17

@etimberg etimberg requested a review from kurkle August 10, 2020 12:12
@stockiNail stockiNail mentioned this pull request Sep 2, 2020
Closed
kurkle
kurkle reviewed Sep 7, 2020
View reviewed changes
src/index.js Outdated Show resolved Hide resolved
@etimberg
Copy link
Member

etimberg commented Sep 7, 2020

Looks like there are some lint issues. Once those are resolved, I'll merge

@stockiNail
Copy link
Contributor Author

Looks like there are some lint issues. Once those are resolved, I'll merge

Lint issues has been removed.

Thanks a lot!

@etimberg etimberg merged commit a0ac796 into chartjs:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix startOf function for isoWeek
3 participants
@stockiNail @etimberg @kurkle