Support node #118
Open
Support node #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Jan 9, 2022
| "package": "npm run build && node scripts/create-packages.js", | ||
| "lint": "eslint docs/**/*.html src/**/*.js test/**/*.js", | ||
| "lint-types": "eslint \"types/**/*.ts\" && tsc -p types/tests/", | ||
| "test": "npm run test-types && npm run test-unit", | ||
| "test-unit": "karma start --single-run --coverage --grep", | ||
| "test-unit:dev": "karma start --auto-watch --grep", | ||
| "test-types": "tsc -p types/tests/" | ||
| "test-types": "tsc -p types/tests/", | ||
| "test-node": "node test/node.js" |
There was a problem hiding this comment.
why have a separate entry point for this? can we just make this a normal test in test/specs like the others?
There was a problem hiding this comment.
The test needed to run on Node not via karma on the browser and this was the simplest way I could think of doing it
There was a problem hiding this comment.
Also, not sure why CI is failing at finding file ./coverage/chrome/lcov.info, is this working in master? I did change some code in that space but a brief review of the changes seem to indicate that it should not change this setting.
|
How do I install this package in nodejs? I try the gulp thing to no avail, anyone in here can hook me up? @SeanSobey ? |
|
@SeanSobey is this PR still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing.
Description
Changed existing code to support and test for NodeJS usability.
Testing
Added a unit test and update the script running infrastructure to support Windows.