Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved samples #5

Closed
mce1978 opened this issue Apr 28, 2017 · 12 comments
Closed

Improved samples #5

mce1978 opened this issue Apr 28, 2017 · 12 comments

Comments

@mce1978
Copy link

mce1978 commented Apr 28, 2017

I just want to try this out. Could you please provide a sample that works out of the box in the samples folder?

I am looking at index.html. Chart.bundle.js could perhaps be a cdn reference? Chart.Financial.js could be prebuilt and available?

Well done!

@benmccann
Copy link
Collaborator

Yes, it will be nice to publish some samples (possibly on GitHub pages) that you can see without checking out the repo

It's useful during development to have samples that point to the local version, so I don't want the version in the samples directory to lose that functionality

@tapir
Copy link

tapir commented Apr 30, 2017

Also sample is now effectively not functional since there is no documentation how to build Chart.Financial.js

@mce1978
Copy link
Author

mce1978 commented Apr 30, 2017

Would it be too much work to add a sample that uses the latest working chart.financial.js ?

I really want to try this but I am not using your build environment.

@benmccann
Copy link
Collaborator

I've added instructions for building to the README

@ShareinSK
Copy link

On which port is the sample running?

@joepsyko
Copy link

Thanks for adding instructions, I tried the chart, I think I'll use it in my project

@ShareinSK
Copy link

ShareinSK commented May 10, 2017

How do I see the sample app?
I have downloaded and installed dependencies.
When i run gulp i dont see the sample app getting started

And how can i include this in my app?

I am new to this. Pls help

@joepsyko
Copy link

You should see the "samples" directory which contains the example

@ShareinSK
Copy link

How can we include this in our app.

@joepsyko
Copy link

see the example, it's self-explanatory

@loicbourgois
Copy link
Contributor

Samples are now available at https://chartjs.github.io/chartjs-chart-financial/
The source is in master/docs

@loicbourgois
Copy link
Contributor

@benmccann should this issue get closed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants