Added PLUGIN ID because missing #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added PLUGIN ID 'annotation" in order to register into Chart.js as required like best practise. In this way you could disable in some chart instances, if you want
remove empty row
osro
added a commit
to osro/chartjs-plugin-annotation
that referenced
this pull request
Jan 28, 2020
* commit '7037eea71314613a8af83d2298241841cbc34c4f': Fix undefined reference "preserveComments" not longer available on gulp-uglify (chartjs#177) Added PLUGIN ID because missing (chartjs#173) allow multiple lines of text in the line label (chartjs#129) Chart.js should be a peerDependency Fix getting chart borders for box size setting (chartjs#152) Fix a number of lint errors in the samples Add missing .htmllintrc Lint sample html (chartjs#150) Pass the index of value datapoint to getPixelValue (chartjs#109) move configure step to draw time, to support render call (chartjs#116) Read plugin options from plugins.annotation (chartjs#130) Add Travis config Add gulp lint task (chartjs#144) Fix Dropbox url # Conflicts: # README.md # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added PLUGIN ID 'annotation" in order to register into Chart.js as required like best practise.
In this way you could disable in some chart instances, if you want