-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable stacked scales and with reverse option support #655
Conversation
@kurkle the stacked scales support is forcing us to change all functions used to get the location of annotations (not only the box ones) because the default dimension is not the chart area anymore but scale one. |
Working on line annotation, I have recognized that the line annotation is working slightly different comparing with the other annotation when the location of the annotation is using Currently the But When #532 will be implemented, this could be taken care, because this could change significantly the chart rendering. |
Conflicts: src/helpers/helpers.chart.js src/types/line.js
Co-authored-by: Jukka Kurkela <jukka.kurkela@gmail.com>
Fix #652
This PR is changing the defaults of
yMin/Max
options when missing.It applies the same logic was implemented in the plugin version < 1.
It adds the control of the scale
reverse
options and stacked scales.Recap about which locate methods is affected: