Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rotation support to label annotation #672

Merged
merged 6 commits into from
Feb 10, 2022
Merged

Enable rotation support to label annotation #672

merged 6 commits into from
Feb 10, 2022

Conversation

stockiNail
Copy link
Collaborator

Fix #660

Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor (and not new) things

src/types/label.js Outdated Show resolved Hide resolved
src/types/label.js Outdated Show resolved Hide resolved
test/fixtures/label/rotation.js Outdated Show resolved Hide resolved
src/types/label.js Outdated Show resolved Hide resolved
@kurkle
Copy link
Member

kurkle commented Feb 7, 2022

Did you miss that comment: #664 (comment)?

@stockiNail
Copy link
Collaborator Author

Did you miss that comment: #664 (comment)?

@kurkle I'm sorry, I missed it. There is a issue: I don't know how the "bump" is working. I have never done. What should I do?

@kurkle
Copy link
Member

kurkle commented Feb 7, 2022

Did you miss that comment: #664 (comment)?

@kurkle I'm sorry, I missed it. There is a issue: I don't know how the "bump" is working. I have never done. What should I do?

I guess there are multiple ways, bu I usually edit the version number in package.json and then run npm i to update the package-lock.json. Commit & create a PR. Thats all :)

@stockiNail
Copy link
Collaborator Author

I guess there are multiple ways, bu I usually edit the version number in package.json and then run npm i to update the package-lock.json. Commit & create a PR. Thats all :)

Fine! I'm doing. Apologize for my lack of knowledge in these internal tasks.... this is my first javascript project where I'm developing ;)

@kurkle
Copy link
Member

kurkle commented Feb 7, 2022

Fine! I'm doing. Apologize for my lack of knowledge in these internal tasks.... this is my first javascript project where I'm developing ;)

Partially why I requested you to do it :)
The other part is that I don't have to open the project, because I'm currently working on multiple others.

@stockiNail
Copy link
Collaborator Author

Partially why I requested you to do it :)
The other part is that I don't have to open the project, because I'm currently working on multiple others.

No problem at all! the first time is always uphill, then all downhill, hopefully...
I'm working on other stuff, but having thought during the weekend how to address the auto position of callout with rotation, I wanted to take time to code and push it in order do not forget the possible solution.

@stockiNail stockiNail marked this pull request as ready for review February 8, 2022 13:09
@stockiNail stockiNail added this to the 1.4.0 milestone Feb 9, 2022
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase

@kurkle kurkle merged commit 51a07f4 into chartjs:master Feb 10, 2022
@stockiNail stockiNail deleted the labelRotation branch February 10, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rotation support to label annotation
2 participants