Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inner chart sample #696

Merged
merged 6 commits into from
Feb 23, 2022
Merged

Add inner chart sample #696

merged 6 commits into from
Feb 23, 2022

Conversation

stockiNail
Copy link
Collaborator

Add ne sample for label annotation.

innerChart

@stockiNail stockiNail added this to the 1.4.0 milestone Feb 23, 2022
LeeLenaleee
LeeLenaleee reviewed Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@LeeLenaleee LeeLenaleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 quick thing that might be out of scope but is a bit of an eyesore to me, will give it a better look later tonight

docs/scripts/utils.js Outdated Show resolved Hide resolved
LeeLenaleee
LeeLenaleee reviewed Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@LeeLenaleee LeeLenaleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice sample, 3 more small things.

docs/samples/label/innerChart.md Outdated Show resolved Hide resolved
docs/scripts/utils.js Outdated Show resolved Hide resolved
docs/samples/label/innerChart.md Outdated Show resolved Hide resolved
stockiNail and others added 2 commits February 23, 2022 20:09
@stockiNail @LeeLenaleee
Update docs/samples/label/innerChart.md
9d10011 
Co-authored-by: Jacco van den Berg <39033624+LeeLenaleee@users.noreply.github.com>
@stockiNail
applies review
435b6fa
@kurkle kurkle merged commit 71c751f into chartjs:master Feb 23, 2022
@stockiNail stockiNail deleted the innerChartSample branch February 23, 2022 19:50
@stockiNail stockiNail mentioned this pull request Feb 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stockiNail @kurkle @LeeLenaleee