Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration guide v2 section to getting started page #709

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Add migration guide v2 section to getting started page #709

merged 3 commits into from
Apr 4, 2022

Conversation

stockiNail
Copy link
Collaborator

Add migration guide v2 section to getting started page

@stockiNail stockiNail added this to the 2.0.0 milestone Mar 7, 2022
@kurkle
Copy link
Member

kurkle commented Mar 7, 2022

While it might not get too long, I think a separate page would be good.

@stockiNail
Copy link
Collaborator Author

While it might not get too long, I think a separate page would be good.

Yes, I thought the same but in CHART.JS the migration guise is inside the Getting started session.
The Getting started plugin is a page and not a group.
group? separated page from getting started? What would you prefer?

@stockiNail stockiNail marked this pull request as ready for review March 8, 2022 10:53
@LeeLenaleee
Copy link
Collaborator

I think I would place at the bottom of the nav, and then when a V3 comes out we can make it into a seperate sub category where we list each migration

@stockiNail
Copy link
Collaborator Author

I think I would place at the bottom of the nav, and then when a V3 comes out we can make it into a seperate sub category where we list each migration

done!

@kurkle
Copy link
Member

kurkle commented Mar 17, 2022

Are we ready to move towards v2?

@stockiNail
Copy link
Collaborator Author

Are we ready to move towards v2?

well, good question. I don't see any other enhancement (or bug) to address, in this moment.
Personally I'm quite busy in this period for a couple of projects but maybe I could find time. Be patient.

And you, what do you think?

@kurkle
Copy link
Member

kurkle commented Mar 17, 2022

Are we ready to move towards v2?

well, good question. I don't see any other enhancement (or bug) to address, in this moment. Personally I'm quite busy in this period for a couple of projects but maybe I could find time. Be patient.

And you, what do you think?

Quite busy too still, so maybe we should wait for a little more then.

@stockiNail
Copy link
Collaborator Author

Quite busy too still, so maybe we should wait for a little more then.

Agree, I've submitted those PRs in order do not forget what I had in mind (getting old it happens) about implementation.

@stockiNail
Copy link
Collaborator Author

Are we ready to move towards v2?

Shall we start version 2.0 on Apr 4th? 4 weeks after version 1.4.0, make sense?

@kurkle
Copy link
Member

kurkle commented Mar 22, 2022

Are we ready to move towards v2?

Shall we start version 2.0 on Apr 4th? 4 weeks after version 1.4.0, make sense?

Sounds good to me!

@stockiNail stockiNail merged commit dda0e5c into chartjs:master Apr 4, 2022
@stockiNail stockiNail deleted the migrationGuide branch April 4, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants