Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require at least chartjs v3.7 #723

Merged
merged 3 commits into from
Apr 11, 2022

Conversation

LeeLenaleee
Copy link
Collaborator

Remove todo for V2.

Although not sure if we want it to be minimal 3.7 because of the bugfix or 3.8 if we want to remove this todo as wel:

/**
* Determine if content is an image or a canvas.
* @param {*} content
* @returns boolean|undefined
* @todo move this function to chart.js helpers
*/
export function isImageOrCanvas(content) {
if (content && typeof content === 'object') {
const type = content.toString();
return (type === '[object HTMLImageElement]' || type === '[object HTMLCanvasElement]');
}
}

@stockiNail stockiNail changed the title require at least chartjs v3.7 Require at least chartjs v3.7 Apr 9, 2022
@stockiNail
Copy link
Collaborator

Although not sure if we want it to be minimal 3.7 because of the bugfix or 3.8 if we want to remove this todo as wel:

In my opinion, I will leave the function in the plugin till the function will be available and released in chartjs.

@LeeLenaleee LeeLenaleee merged commit 8275501 into chartjs:master Apr 11, 2022
@LeeLenaleee LeeLenaleee deleted the chore/v2-min-chartjs-version branch April 11, 2022 08:10
LeeLenaleee added a commit that referenced this pull request Apr 11, 2022
stockiNail pushed a commit that referenced this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants