Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use margin option in the callout check for being shown #742

Merged
merged 3 commits into from
May 19, 2022
Merged

Use margin option in the callout check for being shown #742

merged 3 commits into from
May 19, 2022

Conversation

stockiNail
Copy link
Collaborator

Fix #741

@stockiNail stockiNail added the bug label May 19, 2022
@stockiNail stockiNail added this to the 2.0.0 milestone May 19, 2022
@kurkle
Copy link
Member

kurkle commented May 19, 2022

Not sure what's up with coveralls, but 0% coverage is not acceptable :)

@stockiNail
Copy link
Collaborator Author

Not sure what's up with coveralls, but 0% coverage is not acceptable :)

It seems an issue in coveralls
I will have a look later recommitting something

@stockiNail
Copy link
Collaborator Author

Not sure what's up with coveralls, but 0% coverage is not acceptable :)

Fixed rebasing ;)

@stockiNail stockiNail merged commit da64e92 into chartjs:master May 19, 2022
@stockiNail stockiNail deleted the fixCalloutCheck branch May 19, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Callout is shown even if box label and the margin is beyond the point
2 participants
@stockiNail @kurkle