Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CHART.JS dependency to version 4 #808

Merged
merged 24 commits into from
Nov 17, 2022
Merged

Change CHART.JS dependency to version 4 #808

merged 24 commits into from
Nov 17, 2022

Conversation

stockiNail
Copy link
Collaborator

Fix #807

@stockiNail
Add element diagrams to the annotation types guide
962ee4b
@stockiNail
Merge branch 'master' of https://github.com/chartjs/chartjs-plugin-an…
05e619c 
…notation.git
@stockiNail
Merge branch 'master' of https://github.com/chartjs/chartjs-plugin-an…
22a3aa3 
…notation.git
@stockiNail
Merge branch 'master' of https://github.com/chartjs/chartjs-plugin-an…
f5186fe 
…notation.git
@stockiNail
Merge branch 'master' of https://github.com/chartjs/chartjs-plugin-an…
6d87201 
…notation.git
@stockiNail
Merge branch 'master' of https://github.com/chartjs/chartjs-plugin-an…
84366b3 
…notation.git
@stockiNail
Merge branch 'master' of https://github.com/chartjs/chartjs-plugin-an…
ec3a554 
…notation.git
@stockiNail
Merge branch 'master' of https://github.com/chartjs/chartjs-plugin-an…
1324e43 
…notation.git
@stockiNail
Merge branch 'master' of https://github.com/chartjs/chartjs-plugin-an…
693e84d 
…notation.git
@stockiNail
Merge branch 'master' of https://github.com/chartjs/chartjs-plugin-an…
30b5941 
…notation.git
@stockiNail
Merge branch 'master' of https://github.com/chartjs/chartjs-plugin-an…
b30c95e 
…notation.git
@stockiNail
Merge branch 'master' of https://github.com/chartjs/chartjs-plugin-an…
ff2a323 
…notation.git
@stockiNail
Merge branch 'master' of https://github.com/chartjs/chartjs-plugin-an…
b686c7a 
…notation.git
@stockiNail
Change CHART.JS dependency to version 4
e2ebc2f
@stockiNail stockiNail added the bug label Nov 15, 2022
@stockiNail stockiNail added this to the 2.1.0 milestone Nov 15, 2022
@stockiNail stockiNail marked this pull request as draft November 15, 2022 08:30
@stockiNail stockiNail marked this pull request as ready for review November 15, 2022 14:43
@stockiNail
Copy link
Collaborator Author

Thank you @kurkle for the example to fix docs build issue.
The version in package.json has been set to 2.1.0 if we want to create new version. If yes, I'll change all other PR milestones.

LeeLenaleee
LeeLenaleee previously approved these changes Nov 16, 2022
View reviewed changes
kurkle
kurkle reviewed Nov 17, 2022
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except if I understand the "noDefaultScales" tests right and those are useless tests now?

test/fixtures/box/noDefaultScales.js Outdated Show resolved Hide resolved
@stockiNail stockiNail marked this pull request as draft November 17, 2022 17:56
@stockiNail stockiNail marked this pull request as ready for review November 17, 2022 18:16
kurkle
kurkle approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually for unit tests its better to ise mocked data, so the situation does not change when chart.js changes. But I think this is fine and we can call it integration or functional test :)

@stockiNail
Copy link
Collaborator Author

Ok @kurkle
I did in that way the first impl but I thought you preferred this one.
New version? Bump is already here
If yes I can do it later

@stockiNail stockiNail merged commit 08f92b8 into chartjs:master Nov 17, 2022
@stockiNail stockiNail deleted the chartjs4 branch November 17, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Update Peer dependency
3 participants
@stockiNail @kurkle @LeeLenaleee