Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to version 2.1.1 #822

Merged
merged 4 commits into from
Dec 30, 2022
Merged

Bump to version 2.1.1 #822

merged 4 commits into from
Dec 30, 2022

Conversation

stockiNail
Copy link
Collaborator

Update dependencies

@stockiNail stockiNail added this to the 2.2.0 milestone Dec 22, 2022
@stockiNail stockiNail marked this pull request as ready for review December 24, 2022 09:54
@stockiNail stockiNail modified the milestones: 2.2.0, 2.1.1 Dec 29, 2022
@stockiNail
Copy link
Collaborator Author

@LeeLenaleee @kurkle what do you think if I will change this PR to bump new version 2.1.1? If yes I will do this evening

@kurkle
Copy link
Member

kurkle commented Dec 29, 2022

@LeeLenaleee @kurkle what do you think if I will change this PR to bump new version 2.1.1? If yes I will do this evening

Sounds good to me, quick releases is always better.
Maybe it should still include the destroy hook for v3 compatibility though?

@stockiNail
Copy link
Collaborator Author

@kurkle @LeeLenaleee not needed because the plugin has the dependency with chartjs 3.7.0 and afterDestroy has been introduced in version 3.7.0

@stockiNail stockiNail changed the title Update dependencies Bump to version 2.1.1 Dec 29, 2022
@stockiNail
Copy link
Collaborator Author

Sounds good to me, quick releases is always better.

I have changed version and title of this PR.

@stockiNail stockiNail merged commit 2c4252a into chartjs:master Dec 30, 2022
@stockiNail stockiNail deleted the updateDependencies branch December 30, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stockiNail @kurkle @LeeLenaleee