Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation about label annotation and its positioning #830

Merged
merged 1 commit into from Jan 5, 2023

Conversation

stockiNail
Copy link
Collaborator

Fix #828 #829

@stockiNail stockiNail added this to the 2.2.0 milestone Jan 5, 2023
@stockiNail
Copy link
Collaborator Author

@LeeLenaleee thank you! If I merge it, new draft release 2.1.2 will be created. It's ok or better to go to 2.2.0 in your opinion?

@LeeLenaleee
Copy link
Collaborator

LeeLenaleee commented Jan 5, 2023

2.1.2 since there are no enhancements, but I dont really see a need for a bump 🤔

@stockiNail
Copy link
Collaborator Author

2.1.2 since there are no enhancements, but I dont really see a need for a bump 🤔

Do you know if release-drafter will change the draft release that it created if in the next days a PR with a enhancement will be merged? I don't release-drafter so well :(

@LeeLenaleee
Copy link
Collaborator

Yes if a enhancement gets merged it will since the enhancement will also be released

@stockiNail
Copy link
Collaborator Author

Yes if a enhancement gets merged it will since the enhancement will also be released

THANK YOUU!

@stockiNail stockiNail merged commit 422da1e into chartjs:master Jan 5, 2023
@stockiNail stockiNail deleted the fixLabelDoc branch January 5, 2023 18:04
@stockiNail stockiNail modified the milestones: 2.2.0, 2.1.2 Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Width for Label annotation doesn't work
2 participants