Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define default init animation logic to each annotation element #863

Merged
merged 7 commits into from
May 9, 2023
Merged

Define default init animation logic to each annotation element #863

merged 7 commits into from
May 9, 2023

Conversation

stockiNail
Copy link
Collaborator

@stockiNail stockiNail commented Mar 8, 2023 •
edited

This PR is moving the init animation defaults in a signle poitn and based on annotation type

@stockiNail stockiNail added this to the 3.0.0 milestone Mar 8, 2023
@stockiNail stockiNail changed the title Move default init animation logic to each annotation element Define default init animation logic to each annotation element Mar 8, 2023
@stockiNail stockiNail marked this pull request as ready for review March 16, 2023 21:41
@stockiNail stockiNail requested a review from kurkle March 16, 2023 21:41
@stockiNail
Copy link
Collaborator Author

stockiNail commented Mar 16, 2023 •
edited

Changing the signature of init callback from types stand point, I think it is a breaking change.
@kurkle do you think we could add to version 3 if the code it is ok for you, of course?

EDIT: wait for PR #838 merging because this PR must add the breaking change to migration guide.

@stockiNail stockiNail merged commit 84545be into chartjs:master May 9, 2023
@stockiNail stockiNail deleted the initAnimationInElement branch May 9, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
breaking change enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stockiNail @kurkle