Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix correct drawing when elements are skipped and overlaid #323

Closed
wants to merge 2 commits into from
Closed

Fix correct drawing when elements are skipped and overlaid #323

wants to merge 2 commits into from

Conversation

stockiNail
Copy link
Contributor

Fix #319

@stockiNail stockiNail mentioned this pull request Jun 11, 2022
Closed
@stockiNail
Copy link
Contributor Author

@simonbrunel I have applied the review you suggested

simonbrunel pushed a commit that referenced this pull request Jul 16, 2022
@stockiNail @simonbrunel
Fix drawing order when elements are skipped (#323)
fed9762
@simonbrunel
Copy link
Member

Thanks @stockiNail! This PR has been manually merged (fed9762) since I wanted the test to use bigger labels. I'm not sure why it wasn't enabled for this PR but make sure to check the option to allow maintainers to push to your repository / branch.

@stockiNail
Copy link
Contributor Author

Thanks @stockiNail! This PR has been manually merged (fed9762) since I wanted the test to use bigger labels. I'm not sure why it wasn't enabled for this PR but make sure to check the option to allow maintainers to push to your repository / branch.

It is weird. Usually I fetch al update a from the main before starting a PR.
Anyway thank uou, I’ll pay more attention next time

@simonbrunel
Copy link
Member

I'm thinking about the options "Allow edits by maintainers" when creating the PR (see step 7).

Screenshot 2022-07-16 at 19 40 20

@stockiNail stockiNail deleted the fix319 branch July 18, 2022 06:38
@simonbrunel simonbrunel mentioned this pull request Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbrunel simonbrunel simonbrunel approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Draw order incorrect if empty (null) values in dataset
2 participants
@stockiNail @simonbrunel