Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix category panning #476

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Fix category panning #476

merged 2 commits into from
Apr 30, 2021

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Apr 28, 2021

Fixes #360

  • remove the speed option that was introduced as a workaround and was not really working (increasing speed with increasing zoom, unusable at large zoom levels)
  • determine the visible range from min and max of scale, not relying on ticks at all (those can be skipped / modified, so not reliable)
  • use the chart.pan in tests instead of the hammer-simulator -> faster testing
  • remove duplicate delta handling
  • add tests at different zoom levels

@kurkle kurkle added this to the 1.0.0 milestone Apr 28, 2021
@kurkle kurkle requested a review from etimberg April 29, 2021 17:07
@kurkle kurkle merged commit c7360b1 into chartjs:master Apr 30, 2021
@kurkle kurkle linked an issue May 1, 2021 that may be closed by this pull request
Fix category scale Zoom/Pan proportion problems #151
Closed
@kurkle kurkle mentioned this pull request May 1, 2021
Closed
@kurkle kurkle deleted the category-pan branch July 1, 2021 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
breaking change bug
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Zooming a category axis with the mouse wheel barely works Fix category scale Zoom/Pan proportion problems
2 participants
@kurkle @etimberg